SK-2986 use admin service-account PAT for release version-bump push - #371
Merged
Conversation
Branch protection now enforces PR+approval on main/v1/v3. The automated version-bump commit pushes directly to the release branch as github-actions[bot], which is not a ruleset bypass actor, so the push would be rejected. Point the release checkout at PAT_ACTIONS (skyflow-service-it, a repo admin) so its credential is persisted and reused for the push, which then satisfies the ruleset's repo-admin bypass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
This was referenced Jul 24, 2026
Devesh-Skyflow
added a commit
that referenced
this pull request
Jul 24, 2026
…v1) (#373) Same fix as #371 (main) / #372 (v3), applied to the v1 branch's copy of shared-build-and-deploy.yml. The v1 release pipeline (release-v1.yml) pushes the version-bump commit directly to the protected v1 branch (git push origin HEAD:v1) as github-actions[bot], which is not a ruleset bypass actor, so the push would be rejected. Point the release checkout at PAT_ACTIONS (skyflow-service-it, a repo admin) so its credential is persisted and reused for the push, which then satisfies the ruleset's repo-admin bypass. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Devesh-Skyflow
added a commit
that referenced
this pull request
Aug 3, 2026
…ssing
A reusable workflow only sees secrets declared in its workflow_call
secrets block AND passed by the caller. Repo secrets are not in scope,
unlike in a normal workflow. Two were referenced by their repo names
without being declared, so both evaluated to an empty string:
PAT_ACTIONS
Used as the checkout token. Empty means checkout fails outright with
'Input required and not supplied: token' - the failure on
flowvault-release/26.8.1. Added by #371 (SK-2986) without the
declaration or the pass-through.
TEST_CREDENTIALS_FILE_STRING
Feeds jsdaniell/create-json. Empty means credentials.json was written
empty on every release build - internal and public - and then copied
into each module, with no error at all. Confirmed by comparing the
step's logged inputs: the reusable workflow logs only
'name: credentials.json' with json absent, while the same expression
in pr.yml (not reusable) logs 'json: ***'.
Both are now declared required: true and passed by internal-release.yml
and release.yml, so a future omission fails at the call site rather than
silently emptying out. The checkout token line is restored to keep #371's
intent: the version-bump push uses the admin service account so it
satisfies the branch-protection ruleset's repo-admin bypass.
Audited the whole file: no other undeclared references, and every
declared secret is passed by both callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Branch protection rulesets now enforce PR + 1 approval and the
Teststatus check onmain/v1/v3. The automated release flow (shared-build-and-deploy.yml) pushes the version-bump commit directly to the release branch asgithub-actions[bot], which is not a ruleset bypass actor — so that push would be rejected and releases would break.What
Point the release
actions/checkoutatPAT_ACTIONS(the skyflow-service-it admin service account).checkoutpersists this credential, and the latergit push origin <branch>reuses it — so the push is attributed to a repo admin and satisfies the ruleset's Repository Admin bypass.No ruleset changes required; the bypass is already configured.
This works only if
PAT_ACTIONSis owned by skyflow-service-it (or another repo-admin) and has Contents: write. It is currently used only for the read-only commit-message checker. If it lacks push scope, swaptoken:for a write-capable PAT/App identity that is a bypass actor.Note
This PR is itself the first exercise of the new protection — it requires the
Testcheck to pass and 1 approval before merge.Ref: SK-2986 · SDK Branch Protection — Gap Analysis
🤖 Generated with Claude Code